Skip to content

Add code tabs to the Scala 3 syntax rewriting #2643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2022
Merged

Add code tabs to the Scala 3 syntax rewriting #2643

merged 2 commits into from
Nov 23, 2022

Conversation

KisaragiEffective
Copy link
Contributor

I'm not sure if this could help #2481, let me know (and/or submit RC review) if there are things to be fixed before proceeding. Thank you :)

bishabosha
bishabosha requested changes Nov 21, 2022
View reviewed changes
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few changes to make, but overall great, thanks!

@KisaragiEffective
Copy link
Contributor Author

KisaragiEffective commented Nov 23, 2022 •
edited
Loading

I've fixed all in 61580cf.

@bishabosha bishabosha self-requested a review November 23, 2022 09:07
bishabosha
bishabosha approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@bishabosha bishabosha merged commit 1a82956 into scala:main Nov 23, 2022
@bishabosha bishabosha mentioned this pull request Nov 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishabosha bishabosha bishabosha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KisaragiEffective @bishabosha